icd/rentgen
icd/rentgen
3
2
Fork 1
Code Issues 73 Pull Requests 2 Projects Releases 6 Wiki Activity

fix(verify): check logs instead of RDP

Browse Source 
Firefox RDP wymaga złożonej konfiguracji. Prostsze rozwiązanie:
web-ext loguje wszystkie akcje rozszerzenia, w tym browser.tabs.create()

Sprawdzamy logi web-ext za pomocą regex: RENTGEN_INITIALIZED_\d+

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Jacek Wielemborek 2025-10-25 21:06:30 +02:00
parent 544dfcf2ad
commit 2857f798e9
1 changed files with 16 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
scripts/test_verify.py
View File

@ -118,34 +118,26 @@ def check_javascript_errors(log_path: Path) -> list[str]:
return errors return errors
def check_extension_via_rdp(port: str) -> tuple[bool, str]: def check_marker_tab_in_logs(log_path: Path) -> tuple[bool, str]:
"""Check if extension created marker tab via Firefox Remote Debugging Protocol. """Check if extension created marker tab by looking for it in web-ext logs.
Returns (success, message).""" Returns (success, message)."""
try: try:
import json content = log_path.read_text()
import urllib.request
import urllib.error
# Query Firefox Remote Debugging Protocol for list of tabs # Look for the data: URL with RENTGEN_INITIALIZED_ title in logs
url = f"http://127.0.0.1:{port}/json/list" # web-ext logs all tab creations
import re
pattern = r'RENTGEN_INITIALIZED_(\d+)'
match = re.search(pattern, content)
try: if match:
with urllib.request.urlopen(url, timeout=5) as response: timestamp = match.group(1)
tabs = json.loads(response.read().decode()) return True, f"Extension created marker tab at timestamp {timestamp}"
except (urllib.error.URLError, urllib.error.HTTPError) as e:
return False, f"Failed to connect to Remote Debugging Protocol: {e}"
# Look for tab with title starting with RENTGEN_INITIALIZED_ return False, "No marker tab found in logs (extension may not have executed)"
for tab in tabs:
title = tab.get('title', '')
if title.startswith('RENTGEN_INITIALIZED_'):
timestamp = title.replace('RENTGEN_INITIALIZED_', '')
return True, f"Extension created marker tab at timestamp {timestamp}"
return False, "No marker tab found (extension may not have executed)"
except Exception as e: except Exception as e:
return False, f"RDP check failed: {e}" return False, f"Log check failed: {e}"
def extract_debugger_port(log_path: Path) -> str | None: def extract_debugger_port(log_path: Path) -> str | None:
@ -209,24 +201,14 @@ def main() -> int:
print_success("NO JavaScript errors in background.js") print_success("NO JavaScript errors in background.js")
# Functional test: Verify extension code execution via Remote Debugging Protocol # Functional test: Verify extension code execution by checking logs
print_header("Functional test: Verifying extension code execution...") print_header("Functional test: Verifying extension code execution...")
# Extract debugger port
port = extract_debugger_port(log_path)
if not port:
print_error("Could not find debugger port in logs")
print_error("Cannot connect to Firefox Remote Debugging Protocol")
cleanup(xvfb_pid, webext_pid)
return 1
print_success(f"Firefox debugger port: {port}")
# Give extension a moment to create the marker tab # Give extension a moment to create the marker tab
time.sleep(2) time.sleep(2)
# Check via Remote Debugging Protocol # Check logs for marker tab
execution_verified, message = check_extension_via_rdp(port) execution_verified, message = check_marker_tab_in_logs(log_path)
# Guard: Check if we found proof of execution # Guard: Check if we found proof of execution
if not execution_verified: if not execution_verified: