1
0
forked from icd/rentgen

refactor(docker): replace RUN_TESTS ARG with test stage

- Removed ARG RUN_TESTS and conditional if block
- Added dedicated 'test' stage for quality checks
- Usage: docker build --target test -t rentgen-test .
- Cleaner separation of concerns
- Updated README with new command
This commit is contained in:
Jacek Wielemborek 2025-10-25 20:07:19 +02:00
parent 8b2498642f
commit 00e853de7a
2 changed files with 4 additions and 11 deletions

View File

@ -4,9 +4,6 @@
# Build stage
FROM node:lts AS builder
# Optional: run tests during build (typecheck + lint)
ARG RUN_TESTS=false
WORKDIR /app
# Copy package files for dependency installation (better layer caching)
@ -24,13 +21,9 @@ RUN npm run build
# Create the package
RUN npm run create-package
# Optional: run quality checks
RUN if [ "$RUN_TESTS" = "true" ]; then \
echo "Running TypeScript type checking..."; \
npm run typecheck; \
echo "Running web-ext lint..."; \
npm run lint; \
fi
# Test stage - for running quality checks
FROM builder AS test
RUN npm run typecheck && npm run lint
# Artifacts stage - only contains the built artifacts (for --output)
FROM scratch AS artifacts

View File

@ -54,7 +54,7 @@ This will build the extension and extract the `.zip` file to the `artifacts/` di
### Build with tests (typecheck + lint)
```bash
docker build --build-arg RUN_TESTS=true -t rentgen .
docker build --target test -t rentgen-test .
```
### Traditional build (creates full development environment)